-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block bindings: Add support for creating bindings in templates #57315
Closed
SantosGuillamot
wants to merge
20
commits into
add/block-bindings-api-editor-ui-and-apis
from
add/block-bindings-support-templates
Closed
Block bindings: Add support for creating bindings in templates #57315
SantosGuillamot
wants to merge
20
commits into
add/block-bindings-api-editor-ui-and-apis
from
add/block-bindings-support-templates
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
the
[Feature] Block API
API that allows to express the block paradigm.
label
Dec 21, 2023
SantosGuillamot
added
the
[Type] New API
New API to be used by plugin developers or package users.
label
Dec 21, 2023
Size Change: +262 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
SantosGuillamot
added
[Feature] Custom Fields
Anything related to the custom fields project - connecting block attributes and dynamic values
and removed
[Feature] Block API
API that allows to express the block paradigm.
[Type] New API
New API to be used by plugin developers or package users.
labels
Dec 22, 2023
This was referenced Dec 22, 2023
I believe that these are the remaining issues for this part of the prototype.
|
michalczaplinski
force-pushed
the
add/block-bindings-api-editor-ui-and-apis
branch
4 times, most recently
from
January 11, 2024 19:28
11ba9d7
to
934715b
Compare
Closing this because the block bindings API implementation has changed, and it should follow a different approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Custom Fields
Anything related to the custom fields project - connecting block attributes and dynamic values
[Type] Feature
New feature to highlight in changelogs.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is built on top of #57258
What?
I'm adding the possibility of creating bindings in the templates. As part of that, I'm modifying the "Post meta" source to ensure it works there and to show only the relevant meta for that template:
There are still some aspects to review, especially regarding the UX.
I've recorded this video to showcase how it works for the movies template:
Templating.demo.mp4
Why?
With the current implementation the UI in the editor to connect post meta, doesn't work in templates because it requires a specific ID, which is not available in the template.
How?
Testing Instructions
To do so, you can add a paragraph, click the bindings button, and select the "content" attribute, for example.
This is the list of different templates I identified:
4 . Go to the frontend and check it gets the context correctly.
Remaining issues